Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Condensation! #15

Open
Taverius opened this issue Aug 19, 2014 · 4 comments
Open

Condensation! #15

Taverius opened this issue Aug 19, 2014 · 4 comments

Comments

@Taverius
Copy link

I tried using a density and externaltemp curve to get h20 condensation to work right, but its essentially impossible for a human to tune two curves at once to make it work right at every point.

A custom bit of code that follows the water phase diagram would be useful for 99% of non-SRB 'smoke'.

H2O Phase Diagram

@eggrobin
Copy link
Collaborator

Perhaps not code ad-hoc for H2O, but the ability to select from a range of smoke compositions, these being defined in a separate cfg containing the phase diagram etc. would make it easier to make sensible smoke without replicating lots of information.

@Taverius
Copy link
Author

Sure, being able to input the definition of the condensation curve of a phase diagram would be great.

Still, outside of real fuels and KSPi (and how that would work given the in-flight propellant switch ive no idea) water covers pretty much everything that actually needs a phase-diagram based solution.

@eggrobin
Copy link
Collaborator

Well, there's no way to have this phase diagram without having lots of data (we're not doing computational chemistry). Hardcoding large splines is silly, so we should load them. At that point we can support arbitrary phase diagrams, so let's do that :-p

@eggrobin
Copy link
Collaborator

CO2 exhaust also seems relevant, e.g., it freezes on Titan.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants