Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some resource equations are not parsed correctly #278

Closed
DLBPointon opened this issue Mar 5, 2024 · 1 comment
Closed

Some resource equations are not parsed correctly #278

DLBPointon opened this issue Mar 5, 2024 · 1 comment
Assignees
Labels
bug Something isn't working
Milestone

Comments

@DLBPointon
Copy link
Contributor

Description of the bug

Some of the base.config equations are being parsed incorrectly, for instance:
Miniprot_index has the config

memory = { check_max( 1.GB     * ( fasta.size() < 2e9 ? 30 : Math.ceil( reference.size() / 1e+9 * 50 ) * Math.ceil( task.attempt * 1 ) ) , 'memory') }

With a genome of 1.4Gb is being resolved as 351MB

Needs further investigation, perhaps adding a round up if something is being resolved. as a 0.3 and acting as a division rather than multiplier

Command used and terminal output

TERM_MEMLIMIT: job killed after reaching LSF memory usage limit.
  Exited with exit code 130.
  
  Resource usage summary:
  
      CPU time :                                   0.10 sec.
      Max Memory :                                 351 MB
      Average Memory :                             122.33 MB
      Total Requested Memory :                     -
      Delta Memory :                               -
      Max Swap :                                   -
      Max Processes :                              15
      Max Threads :                                29
      Run time :                                   4 sec.
      Turnaround time :                            5 sec.

Relevant files

No response

System information

No response

@DLBPointon DLBPointon added the bug Something isn't working label Mar 5, 2024
@DLBPointon DLBPointon added this to the Release 1 milestone Mar 5, 2024
@DLBPointon DLBPointon self-assigned this Mar 5, 2024
@DLBPointon
Copy link
Contributor Author

DLBPointon commented Mar 6, 2024

Also occuring with Minimap2_align

        memory = { check_max( 1.GB     * ( reference.size() < 2e9 ? 30 : Math.ceil( ( reference.size() / 1e+9 ) * 20 ) * Math.ceil( task.attempt * 1 ) ) , 'memory') }

Resolved to 115MB

I think this is an edge case with certain genome sizes causing the error

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant