Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Removing extra spaces in config #182

Merged
merged 1 commit into from
Nov 28, 2023
Merged

Removing extra spaces in config #182

merged 1 commit into from
Nov 28, 2023

Conversation

DLBPointon
Copy link
Contributor

Very small PR.
Removes 4 extra spaces which were stopping the config being parsed properly. This was non-fatal as the pipeline just didn't recognise the process with the extra spaces, which is why it still passed tests.

Closes #181

@DLBPointon DLBPointon added bug Something isn't working Release 1.1 Issues to be resolved for minor release 1.1 labels Nov 24, 2023
@DLBPointon DLBPointon added this to the Release 1 milestone Nov 24, 2023
@DLBPointon DLBPointon self-assigned this Nov 24, 2023
@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 24, 2023 •
edited
Loading

nf-core lint overall result: Passed ✅ ⚠️

Posted for pipeline commit 326747d

+| ✅ 127 tests passed       |+
#| ❔  17 tests were ignored |#
!| ❗   7 tests had warnings |!

❗ Test warnings:

  • files_exist - File not found: conf/igenomes.config
  • files_exist - File not found: .github/workflows/awstest.yml
  • files_exist - File not found: .github/workflows/awsfulltest.yml
  • nextflow_config - Config manifest.version should end in dev: '1.0.2'
  • pipeline_todos - TODO string in methods_description_template.yml: ## Update the HTML below to your prefered methods description, e.g. add publication citation for this pipeline
  • pipeline_todos - TODO string in WorkflowMain.groovy: Add Zenodo DOI for pipeline after first release
  • system_exit - System.exit in WorkflowTreeval.groovy: System.exit(1) [line 17]

❔ Tests ignored:

  • files_exist - File is ignored: assets/nf-core-treeval_logo_light.png
  • files_exist - File is ignored: conf/test_full.config
  • files_exist - File is ignored: docs/images/nf-core-treeval_logo_light.png
  • files_exist - File is ignored: docs/images/nf-core-treeval_logo_dark.png
  • nextflow_config - Config variable ignored: manifest.name
  • nextflow_config - Config variable ignored: manifest.homePage
  • files_unchanged - File ignored due to lint config: LICENSE or LICENSE.md or LICENCE or LICENCE.md
  • files_unchanged - File ignored due to lint config: .github/CONTRIBUTING.md
  • files_unchanged - File ignored due to lint config: .github/ISSUE_TEMPLATE/bug_report.yml
  • files_unchanged - File ignored due to lint config: .github/workflows/linting.yml
  • files_unchanged - File ignored due to lint config: assets/sendmail_template.txt
  • files_unchanged - File does not exist: assets/nf-core-treeval_logo_light.png
  • files_unchanged - File does not exist: docs/images/nf-core-treeval_logo_light.png
  • files_unchanged - File does not exist: docs/images/nf-core-treeval_logo_dark.png
  • files_unchanged - File ignored due to lint config: lib/NfcoreTemplate.groovy
  • files_unchanged - File ignored due to lint config: .gitignore or .prettierignore or pyproject.toml
  • actions_awstest - 'awstest.yml' workflow not found: /home/runner/work/treeval/treeval/.github/workflows/awstest.yml

✅ Tests passed:

Run details

  • nf-core/tools version 2.8
  • Run at 2023-11-24 16:26:44

@yumisims
Copy link
Contributor

looks good to me

@DLBPointon DLBPointon requested a review from yumisims November 28, 2023 15:19
yumisims
yumisims approved these changes Nov 28, 2023
View reviewed changes
Copy link
Contributor

@yumisims yumisims left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@DLBPointon DLBPointon merged commit 460268b into dev Nov 28, 2023
6 checks passed
@DLBPointon DLBPointon deleted the dp24_config_correction branch November 28, 2023 15:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yumisims yumisims yumisims approved these changes

Assignees

@DLBPointon DLBPointon

Labels
bug Something isn't working Release 1.1 Issues to be resolved for minor release 1.1
Projects
None yet
Milestone
Release 1
Development

Successfully merging this pull request may close these issues.

Too many spaces in config stop better resource allocation
2 participants
@DLBPointon @yumisims