Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release 0.3 #92

Merged
merged 45 commits into from
Feb 12, 2024
Merged

Release 0.3 #92

merged 45 commits into from
Feb 12, 2024

Conversation

muffato
Copy link
Member

@muffato muffato commented Feb 9, 2024

The only change compared to main is the PR you accepted this morning (#88) and a commit (21db9cf) in which I've bumped the version number up

PR checklist

  • This comment contains a description of changes (with reason).
  • If you've fixed a bug or added code that should be tested, add tests!
  • If you've added a new tool - have you followed the pipeline conventions in the contribution docs
  • Make sure your code lints (nf-core lint).
  • Ensure the test suite passes (nextflow run . -profile test,docker --outdir <OUTDIR>).
  • Check for unexpected warnings in debug mode (nextflow run . -profile debug,test,docker --outdir <OUTDIR>).
  • Usage Documentation in docs/usage.md is updated.
  • Output Documentation in docs/output.md is updated.
  • CHANGELOG.md is updated.
  • README.md is updated (including new tool citations and authors/contributors).

muffato added 30 commits January 9, 2024 11:20
only run BLAST_BLASTN if BLASTN_TAXON has an empty output
With the `-0` option, the output file ("interleaved") is empty for PacBio
because all the reads go to the "other" file. Whereas paired-reads all go to
the "interleaved" file and none to the "other" file.

The simplest is to not use the `-0` option. Then, `samtools fasta` simply sends
all the reads to the standard output.
This simplifies connecting to the fetchngs pipeline
This means that .fastq.gz will remain .fastq.gz and can then match the
condition to bypass the SAMTOOLS_FASTA process.

There is a pull-request for this, nf-core/modules#4230
@muffato muffato requested a review from BethYates February 9, 2024 16:05
@muffato muffato self-assigned this Feb 9, 2024
Copy link

github-actions bot commented Feb 9, 2024

nf-core lint overall result: Passed ✅ ⚠️

Posted for pipeline commit aabcfc6

+| ✅ 134 tests passed       |+
#| ❔  23 tests were ignored |#
!| ❗   1 tests had warnings |!

❗ Test warnings:

❔ Tests ignored:

  • files_exist - File is ignored: CODE_OF_CONDUCT.md
  • files_exist - File is ignored: assets/nf-core-blobtoolkit_logo_light.png
  • files_exist - File is ignored: docs/images/nf-core-blobtoolkit_logo_light.png
  • files_exist - File is ignored: docs/images/nf-core-blobtoolkit_logo_dark.png
  • files_exist - File is ignored: .github/ISSUE_TEMPLATE/config.yml
  • files_exist - File is ignored: .github/workflows/awstest.yml
  • files_exist - File is ignored: .github/workflows/awsfulltest.yml
  • files_exist - File is ignored: conf/igenomes.config
  • nextflow_config - Config variable ignored: manifest.name
  • nextflow_config - Config variable ignored: manifest.homePage
  • files_unchanged - File ignored due to lint config: CODE_OF_CONDUCT.md
  • files_unchanged - File ignored due to lint config: LICENSE or LICENSE.md or LICENCE or LICENCE.md
  • files_unchanged - File ignored due to lint config: .github/ISSUE_TEMPLATE/bug_report.yml
  • files_unchanged - File does not exist: .github/ISSUE_TEMPLATE/config.yml
  • files_unchanged - File ignored due to lint config: .github/PULL_REQUEST_TEMPLATE.md
  • files_unchanged - File ignored due to lint config: .github/workflows/linting.yml
  • files_unchanged - File ignored due to lint config: assets/nf-core-blobtoolkit_logo_light.png
  • files_unchanged - File ignored due to lint config: docs/images/nf-core-blobtoolkit_logo_light.png
  • files_unchanged - File ignored due to lint config: docs/images/nf-core-blobtoolkit_logo_dark.png
  • files_unchanged - File ignored due to lint config: lib/NfcoreTemplate.groovy
  • actions_awstest - 'awstest.yml' workflow not found: /home/runner/work/blobtoolkit/blobtoolkit/.github/workflows/awstest.yml
  • template_strings - template_strings
  • merge_markers - merge_markers

✅ Tests passed:

Run details

  • nf-core/tools version 2.11
  • Run at 2024-02-10 09:49:36

@muffato
Copy link
Member Author

muffato commented Feb 10, 2024

I've added another commit (aabcfc6) after realising that the nf-validation plugin doesn't allow integers on "string" types !

@muffato muffato merged commit 2a8f760 into main Feb 12, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants