-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Release 0.3 #92
Merged
Release 0.3 #92
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
only run BLAST_BLASTN if BLASTN_TAXON has an empty output
With the `-0` option, the output file ("interleaved") is empty for PacBio because all the reads go to the "other" file. Whereas paired-reads all go to the "interleaved" file and none to the "other" file. The simplest is to not use the `-0` option. Then, `samtools fasta` simply sends all the reads to the standard output.
(waiting for nf-core approval)
This simplifies connecting to the fetchngs pipeline
…uses some problems
This means that .fastq.gz will remain .fastq.gz and can then match the condition to bypass the SAMTOOLS_FASTA process. There is a pull-request for this, nf-core/modules#4230
This reverts commit 5e7d53a.
…object is a path, not a list
Since the blobdir is incrementally built, only the last version needs to be published
v0.3 - Pipeline now validated on five real genomes
|
I've added another commit (aabcfc6) after realising that the nf-validation plugin doesn't allow integers on "string" types ! |
BethYates
approved these changes
Feb 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The only change compared to main is the PR you accepted this morning (#88) and a commit (21db9cf) in which I've bumped the version number up
PR checklist
nf-core lint
).nextflow run . -profile test,docker --outdir <OUTDIR>
).nextflow run . -profile debug,test,docker --outdir <OUTDIR>
).docs/usage.md
is updated.docs/output.md
is updated.CHANGELOG.md
is updated.README.md
is updated (including new tool citations and authors/contributors).