Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DOI Logging #47

Open
regniets opened this issue Apr 9, 2020 · 4 comments
Open

DOI Logging #47

regniets opened this issue Apr 9, 2020 · 4 comments

Comments

@regniets
Copy link

regniets commented Apr 9, 2020

Depending on what happens behind the Login one might need a proper logging of the double opt in process (who registered when, who confirmed when at least). Would be great if the plugin could deliver this out of the box, maybe with a featureToggle.
(thanks for the very useful tool though!)

@skurfuerst
Copy link
Member

Hey @regniets :)

Great idea :) I currently do not have time to develop this, though in corona times ;). Would you be up for creating a PR?

All the best,
Sebastian

@regniets
Copy link
Author

Hi @skurfuerst,

I just implemented a quick AOP workaround with a logger, but I am indecisive whether it shoud be in a log file or in the database - since it is only important in rare legal cases and has no real meaning for the domain model...
What do you think?
When I am done, I will provide you with a PR.

Cheers,
Stefan

@skurfuerst
Copy link
Member

Hey @regniets ,

After some thinking, I'd suggest using a database, because:

  • often Log files are more temporary (i.e. moved off / deleted after a while), while a Database is very likely part of a regular, persistent backup.
  • We can make this part of the UserManagement Domain Model (with a DB table etc), but whether it is filled or not should IMHO be controlled by a new Setting, which defaults to off. IMHO this new table does not hurt, so it's OK to have it included here :)
  • Additionally, you can add a Signal at the right place, so if the persistence via Domain Model is not enough for some very specific use cases, one could hook into there and persist it "however and how revision safe one needs" :-)

What do you think?

All the best, and thanks for your work,
Sebastian

@regniets
Copy link
Author

Hi @skurfuerst,

Good solution, so as soon as i get to implement it, I am going to do a PR.

Cheers,
Stefan

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants