Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BUG: packageKey dont show up in generateCrudController in console output #24

Open
crydotsnake opened this issue Nov 10, 2023 · 0 comments · May be fixed by #25
Open

BUG: packageKey dont show up in generateCrudController in console output #24

crydotsnake opened this issue Nov 10, 2023 · 0 comments · May be fixed by #25

Comments

@crydotsnake
Copy link
Contributor

crydotsnake commented Nov 10, 2023 •
edited
Loading

Description

Currenty when kickstart the needed files it doesent show the $packageKey in the generateCrudController method.

Screenshot

SCR-20231110-pltq

This is caused by a / which is in the getNamespaceBaseDirectory() method:

CrudForms/Classes/Command/CrudGeneratorService.php

Line 151 in fe9499f

return Files::getNormalizedPath($package->getPackagePath() . '/Classes/');

When removing the / the output looks as i would expect it:

SCR-20231110-pokz

I suspect the reason for this is that there is already a / here. And therefore it could not resolve the path correctly.

CrudForms/Classes/Command/CrudGeneratorService.php

Lines 137 to 139 in fe9499f

$this->generatedFiles[] = 'Created .../' . $relativeTargetPathAndFilename;
} else {
$this->generatedFiles[] = 'Omitted .../' . $relativeTargetPathAndFilename;

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

BUGFIX: missing packageKey in console output in generateCrudController crydotsnake/CrudForms
1 participant
@crydotsnake