Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unclear findElement/findElementWithAssert import path #388

Closed
ro0gr opened this issue Mar 8, 2018 · 3 comments
Closed

Unclear findElement/findElementWithAssert import path #388

ro0gr opened this issue Mar 8, 2018 · 3 comments

Comments

@ro0gr
Copy link
Collaborator

ro0gr commented Mar 8, 2018

findElement and findElementWithAssert are currently exported from index.js and and extend.js.
Different import paths are also suggested in the docs for these helpers.

I feel importing it from ember-cli-page-object/extend is a recommended way but want to confirm first.
If so we should likely deprecate the other import path and fix the docs.

@san650
Copy link
Owner

san650 commented Mar 9, 2018

The idea is to use the ember-cli-page-object/extend path. Let's deprecate the other export path!.

@san650 san650 mentioned this issue May 10, 2018
18 tasks
@ro0gr
Copy link
Collaborator Author

ro0gr commented Dec 14, 2018

I think findElement/findElementWithAssert should be deprecated and removed from v2 in favour of new native DOM finder alternative.

Need a ticket for that new method(s) design.

@ro0gr
Copy link
Collaborator Author

ro0gr commented Oct 25, 2019

finally #463

@ro0gr ro0gr closed this as completed Oct 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants