Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document that custom helpers can be used for anything, not just components #210

Open
benshine opened this issue Jul 5, 2016 · 3 comments
Assignees

Comments

@benshine
Copy link

benshine commented Jul 5, 2016

Currently, the only description of writing custom helpers is in the section on components:
http://ember-cli-page-object.js.org/docs/v1.4.x/components#custom-helper

I found out in emberjs slack from @jeradg that "The custom helpers will work in components, page objects, collections, etc."

It would be great if that info were in the actual documentation :)

@san650
Copy link
Owner

san650 commented Jul 6, 2016

Thanks for the feedback, it's really useful to help us improving the addon.

@jeradg jeradg self-assigned this Aug 1, 2016
@jeradg
Copy link
Contributor

jeradg commented Aug 1, 2016

@benshine @san650 Time for me to take that Slack wisdom and put it in the repo!

@jeradg
Copy link
Contributor

jeradg commented Aug 13, 2016

Note (also from a conversation with @benshine on Slack): We also need documentation that you can add plain JS methods to the page object. In those methods, you can refer to the PO with the this keyword, return this to allow for method chaining, etc.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants