Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve file storage logic #69

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Improve file storage logic #69

wants to merge 1 commit into from

Conversation

samwilson
Copy link
Owner

  • Use BoxedCommand for shelling out.
  • Remove separate preview logic (which wasn't working anyway).
  • Correctly check for existing file, and return its URL.
  • Use sha1 instead of MD5 for filename hash.
  • Better error display (remove outer paragraph, so it gets .error class).
  • Update required core version to 1.40.

@samwilson
Improve file storage logic
1880088 
* Use BoxedCommand for shelling out.
* Remove separate preview logic (which wasn't working anyway).
* Correctly check for existing file, and return its URL.
* Use sha1 instead of MD5 for filename hash.
* Better error display (remove outer paragraph, so it gets .error class).
* Update required core version to 1.40.
@samwilson
Copy link
Owner Author

I'll chop this up into sensible separate PRs… this is just for discussion really… :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@samwilson