Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added slideshow start info back in from blacklight. #2394

Merged
merged 2 commits into from
Dec 3, 2024
Merged

Added slideshow start info back in from blacklight. #2394

merged 2 commits into from
Dec 3, 2024

Conversation

sephirothkod
Copy link
Collaborator

Blacklight has removed the info for how to start the slideshow. Not sure why it was removed here, without comment. It is probably better to have it in hyku so there is no worry about it being arbitrarily changed in the future. This change applies specifically to the public show page of collections.

@samvera/hyku-code-reviewers

@sephirothkod sephirothkod added the patch-ver for release notes label Nov 28, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 28, 2024 •
edited
Loading

Test Results

    3 files  ±0      3 suites  ±0   18m 10s ⏱️ +13s
2 053 tests ±0  2 003 ✅ ±0  50 💤 ±0  0 ❌ ±0 
2 080 runs  ±0  2 028 ✅ ±0  52 💤 ±0  0 ❌ ±0 

Results for commit ff57b3b. ± Comparison against base commit f76a5d5.

This pull request removes 42 and adds 42 tests. Note that renamed tests count towards both. 
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor Etd permissions is expected not to be able to destroy 77435634-9f8a-4df5-b52a-640a706aab69
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor Etd permissions is expected not to be able to edit cc718ba4-1958-499c-b948-1313ebb5dab9
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor Etd permissions is expected not to be able to read 88a4c3a2-26da-4610-b74d-c351fd8ee64b
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor Etd permissions is expected not to be able to update c053bd4f-991b-4ec9-981c-8fd1076e3f4a
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor FileSet permissions is expected not to be able to destroy bf1206b2-4a11-4851-9251-525c94f6a5e7
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor FileSet permissions is expected not to be able to edit 2150fe91-65be-4f84-be1b-d672261d506b
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor FileSet permissions is expected not to be able to read 6bca7913-538c-4f66-973b-f9c0a62e4da2
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor FileSet permissions is expected not to be able to update 3aaff1b3-1060-4ece-b98e-0c50428811cf
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor GenericWork permissions is expected not to be able to destroy 8ff865c6-c83d-42ff-a9f2-a189c221aac3
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor GenericWork permissions is expected not to be able to edit e90a89e4-252b-4ddf-b5f2-f1efaee9c3f8
…

spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor Etd permissions is expected not to be able to destroy f9734ad5-863f-450f-8e5d-5eaa1c5ff32c
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor Etd permissions is expected not to be able to edit b805deb1-0c54-451c-9553-bef1e8ca909e
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor Etd permissions is expected not to be able to read d02cef4f-d77b-4cad-abe1-5968a8eda6ea
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor Etd permissions is expected not to be able to update 799ad277-ce5f-4182-9e6a-652030bccfd0
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor FileSet permissions is expected not to be able to destroy 068bf99f-e04d-40d2-a35c-ec38ad13d67a
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor FileSet permissions is expected not to be able to edit 9b688027-b6fb-4bf9-beb4-1c42d111bd56
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor FileSet permissions is expected not to be able to read 17fd5306-a96e-4844-b189-ff6a9d194c5e
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor FileSet permissions is expected not to be able to update 64b19af2-991e-4e55-8bdc-a5008635377e
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor GenericWork permissions is expected not to be able to destroy 18f77a01-b504-4a51-8ec9-dee36880c2b9
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor GenericWork permissions is expected not to be able to edit 1c9bfbcb-c658-46de-ab9f-283e57522f45
…

♻️ This comment has been updated with latest results.

@sephirothkod sephirothkod merged commit 6ad1bb1 into main Dec 3, 2024
8 of 9 checks passed
@sephirothkod sephirothkod deleted the 2355-slideshow_info branch December 3, 2024 22:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bkiahstroud bkiahstroud bkiahstroud approved these changes

Assignees
No one assigned
Labels
patch-ver for release notes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sephirothkod @bkiahstroud