New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Modal partial has layout issue in 2.x branches #409

Open

eliotjordan opened this issue Jun 29, 2022 · 0 comments

eliotjordan commented Jun 29, 2022

In 2.x branches, the modal partial has a layout error. The h4 tag should come before the button tag.

browse-everything/app/views/browse_everything/_modal.html.erb

Lines 5 to 8 in 516d8e7

    
           <button type="button" class="close" data-dismiss="modal" aria-label="Close"> 
        
             <span aria-hidden="true">&times;</span> 
        
           </button> 
        
           <h4 class="modal-title" id="browse-everything-modal-title">Select Your Files</h4>

The text was updated successfully, but these errors were encountered:

eliotjordan changed the title ~~Modal partial has issue in 2.x branches~~ Modal partial has layout issue in 2.x branches

eliotjordan mentioned this issue

Fix bulk edit form and browse everything modal pulibrary/figgy#5215

Merged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment