set_wwr removes doors

[szvsw]

When calling set_wwr, doors get inadvertently popped in this snippet here:

archetypal/archetypal/idfclass/idf.py

Lines 2359 to 2380 in 5393b96

	if wall_subsurfaces and not construction:
	constructions = list(
	{
	wss.Construction_Name
	for wss in wall_subsurfaces
	if _is_window(wss)
	}
	)
	if len(constructions) > 1:
	raise ValueError(
	'Not all subsurfaces on wall "{name}" have the same construction'.format(
	name=wall.Name
	)
	)
	construction = constructions[0]
	if len(wall_subsurfaces) == 0 and not force:
	# Don't create windows on walls that don't have any windows already.
	continue
	# remove all subsurfaces
	for ss in wall_subsurfaces:
	self.rename(ss.key.upper(), ss.Name, "%s window" % wall.Name)
	self.removeidfobject(ss)

Now it's not necessarily an issue, since this style of setting the WWR sets large windows that span the length of the wall, so they would be conflicting with any existing doors; ultimately this method is not really meant to be used with a model that has doors I suppose.

Having said that, there should probably be a comment about this in docstring, and/or a warning raised when popping non-window subsurfaces.

[szvsw]

Just wanted to get your thoughts on this @samuelduchesne

[samuelduchesne]

I'm not sure I get where Doors are affected. in the self.removeidfobject call?

[szvsw]

exactly - they are one of the subsurfaces