Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: adding Green, Yellow, Red to emphasize scores #34

Open
luuu-xu opened this issue Aug 23, 2023 · 1 comment
Open

Feature: adding Green, Yellow, Red to emphasize scores #34

luuu-xu opened this issue Aug 23, 2023 · 1 comment

Comments

@luuu-xu
Copy link
Contributor

luuu-xu commented Aug 23, 2023

I also think it is another good feature if we can change the scores' text colours to, let's say, for AAA you get #22C55E green, and for AA you get #FACC15 yellow, and for Fail you get #EF4444 red.

What do you think?

Oh, and also I think it would be great to save the light/dark background colours in localStorage so users can access them easily next time using the website?

@samrobbins85
Copy link
Owner

I'm not sure about this one, as black and white have fairly good contrast against the background which might be lost by changing to RGB, making the scores difficult to read.

Localstorage implementation sounds good though!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants