Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When we increment on click, should we update storage? #17

Open
danpastori opened this issue Oct 4, 2018 · 1 comment
Open

When we increment on click, should we update storage? #17

danpastori opened this issue Oct 4, 2018 · 1 comment

Comments

@danpastori
Copy link
Contributor

Problem

We have a flag for incrementing the count on click. This doesn't update the storage so if I refresh the page my click isn't stored.

Rationale

It can be kind of misleading when I see an increment, refresh the page and it isn't there.

Solution

Update the storage if increment is set.

Pros of Solution:

Refreshing the page will show the new share.

Cons of Solution:

If I click and didn't share, then the number will be wrong and won't correct itself until the cache expires.

Let me know your thoughts on this and we can find a way to resolve this issue!

@sampotts
Copy link
Owner

sampotts commented Feb 17, 2019

I'd say no on this since the increment assumes the share took place. It would get confusing if we're manipulating the source data. Perhaps what we could do is invalidate the cache for that URL/network on click?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants