Fix loading menus locally #8
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes a bug where menus would always be loaded remotely, so local config didn't apply. Also simplifies the config a bit.
Avoids downloading the menus every time
samdbmg
force-pushed
the
fix/loading-local-menus
branch
from
8c37087
to
36de3c3
Compare
This was referenced Jul 23, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reworks the dnsmasq config to correctly set the
next-serverand make sure one of theissettests here succeeds instead of falling back to the menus hosted by netboot.xyzTested with a BIOS and a UEFI VM locally, confirmed that the next server gets set and I can change the
win_base_urlin boot.cfg and have that work as well.Fixes #6
Fixes #7