Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Samsung Pass and Samsung Pay support #43

Closed
Pharaoh2k opened this issue Aug 10, 2023 · 15 comments
Closed

Samsung Pass and Samsung Pay support #43

Pharaoh2k opened this issue Aug 10, 2023 · 15 comments

Comments

@Pharaoh2k
Copy link

Very useful project, thank you! :)
Any plans to add Samsung pass and Samsung pay support?

@salvogiangri
Copy link
Owner

Fixing those two apps is not possible because the device integrity checks run in TEE. I shared more details in the XDA thread of the module (Post #28, Post #29).

Screenshot 2023-02-10 alle 09 50 03 Screenshot 2023-08-11 alle 10 53 57 Screenshot 2023-08-11 alle 10 55 36

@salvogiangri salvogiangri closed this as not planned Won't fix, can't repro, duplicate, stale Aug 11, 2023
@mario6714
Copy link

Sorry to comment here, one question, Samsung cant apply that (security) in the others apps? thanks

@salvogiangri
Copy link
Owner

Sorry to comment here, one question, Samsung cant apply that (security) in the others apps? thanks

Nothing is impossible, I will of course keep an eye on the changes that might be implemented in the next Android iterations. As per the latest One UI 6 beta, their API’s haven’t changed.

@mario6714
Copy link

Ok, thanks, i have a Samsung phone, can unlock bootloader (still off) but still not doing a root.

@mio-19
Copy link

mio-19 commented Sep 4, 2023

Fixing those two apps is not possible because the device integrity checks run in TEE. I shared more details in the XDA thread of the module (Post #28, Post #29).

Screenshot 2023-02-10 alle 09 50 03 Screenshot 2023-08-11 alle 10 53 57 Screenshot 2023-08-11 alle 10 55 36

I am wondering if it is possible to patch by modifying the binary of the Samsung Pay app or kernel

@Pharaoh2k
Copy link
Author

Fixing those two apps is not possible because the device integrity checks run in TEE. I shared more details in the XDA thread of the module (Post #28, Post #29).
Screenshot 2023-02-10 alle 09 50 03 Screenshot 2023-08-11 alle 10 53 57 Screenshot 2023-08-11 alle 10 55 36

I am wondering if it is possible to patch by modifying the binary of the Samsung Pay app or kernel

Even if it's possible, would you use a modified binary of a wallet app? I certainly wouldn't take that risk

@mio-19
Copy link

mio-19 commented Sep 4, 2023

Fixing those two apps is not possible because the device integrity checks run in TEE. I shared more details in the XDA thread of the module (Post #28, Post #29).
Screenshot 2023-02-10 alle 09 50 03 Screenshot 2023-08-11 alle 10 53 57 Screenshot 2023-08-11 alle 10 55 36

I am wondering if it is possible to patch by modifying the binary of the Samsung Pay app or kernel

Even if it's possible, would you use a modified binary of a wallet app? I certainly wouldn't take that risk

I would trust a binary modified by myself.

@Pharaoh2k
Copy link
Author

Then go for it

@salvogiangri
Copy link
Owner

I am wondering if it is possible to patch by modifying the binary of the Samsung Pay app or kernel

It's not possible. Even if you manage to bypass the anti-tamper check in the apps such as anti-hook, APK signature check in Samsung Account etc. you'd still need to patch the trustlets, which can't be done since they're signed as well. The only possible way (imho) would be via a TrustZone exploit

@salvogiangri salvogiangri pinned this issue Sep 4, 2023
@mio-19
Copy link

mio-19 commented Sep 15, 2023

Does this also apply to Samsung Pay Watch plugin-in?
This app:
Screenshot_20230915_222119_MT Manager

@salvogiangri
Copy link
Owner

Does this also apply to Samsung Pay Watch plugin-in?

This app:

Screenshot_20230915_222119_MT Manager

No, the watch plugin should work fine as long as you have the Enhancer module installed.

@n00b69
Copy link

n00b69 commented Nov 1, 2023

What's different about Samsung Pass on devices running Android 7 or lower which makes it work even when rooted? Would it theoretically not be possible to spoof the app to think it's running on something like a Galaxy S7 on Android 7?

@salvogiangri
Copy link
Owner

I never saw those two apps working even on legacy OS.

@egydoctor2010
Copy link

Know with trick store and valid keybox some devices pass strong and tee passed so can we get this 2 apps working now or still ?

@salvogiangri
Copy link
Owner

Know with trick store and valid keybox some devices pass strong and tee passed so can we get this 2 apps working now or still ?

Play Integrity/Key attestation is not used to verify the device integrity in Pass/Wallet. Read #43 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants