Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compatibility issue with combat carousel control button #80

Closed
yjeroen opened this issue Jan 13, 2022 · 3 comments
Closed

Compatibility issue with combat carousel control button #80

yjeroen opened this issue Jan 13, 2022 · 3 comments
Labels
compatibility Issue with specific module or system

Comments

@yjeroen
Copy link

yjeroen commented Jan 13, 2022

image

The combat carousel icon (on the bottom) isn't made smaller.

<li class="scene-control " data-control="effects" data-canvas-layer="specials" title="Effect Controls">
            <i class="fas fa-magic"></i>
        </li>

<li class="scene-control" data-control="combat-carousel" title="Combat Carousel - click to toggle visibility, right-click to reset position">
    <img src="modules/combat-carousel/icons/empty-carousel-solid.svg" class="carousel-icon">
    <div class="wrapper">
        <i class="fas fa-caret-down collapse-indicator"></i>
    </div>
</li>
@saif-ellafi
Copy link
Owner

saif-ellafi commented Jan 14, 2022

Hi @yjeroen thanks for reporting this

Not my intention to sound blunt, but Minimal UI does not make any particular distinction between control buttons. Adding a particular exception for Combat Carousel would be unfair from my side. This should be reported over to Combat Caroussel, so the module owner uses standard Controls properties, like the rest of the buttons.

@saif-ellafi saif-ellafi added the compatibility Issue with specific module or system label Jan 14, 2022
@yjeroen
Copy link
Author

yjeroen commented Jan 14, 2022

Understand your point!
I've also opened an issue on their end:
death-save/combat-carousel#125

@saif-ellafi
Copy link
Owner

Thank you, I hope this can be resolved on the other side of the story! It is indeed a nice module. Ping me again if you get resistance on the other side, I can consider some hacky wacky stuff, but hopefully not!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
compatibility Issue with specific module or system
Projects
None yet
Development

No branches or pull requests

2 participants