You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Namely 3:
I do not understand what does the first one do. The second one is very clear because it is not just abstract "Cancel". The one on the bottom is very confusing when the payment details are not open - it looks like "Cancel this pending payment". It seems to me that the bottom two buttons Cancel/OK have exactly the same function and the same effect is achieved by clicking on X in the top right corner or just outside the modal. I would get rid of them completely to avoid confusion.
Not sure what should be done about the first Cancel - either renamed to make it clear or eliminate if it is not necessary.
The text was updated successfully, but these errors were encountered:
Not sure what should be done about the first Cancel - either renamed to make it clear or eliminate if it is not necessary.
This component is used in probably 10 different places. If we remove that cancel button, there may be places where people get frustratingly stuck and/or have to refresh their browser or something else.
The above are just for the overall balance modal. They have nothing to do with the payments component.
This ticket is too vague and I'm very reluctant to make ANY of the changes suggested here without significantly more discussion and thought, as they all have the potential to cause subtle bugs at a distance and/or just directly conflict with the overall design decisions of Antd (e.g., all modals have a footer with Cancel/OK by default). I'm also removing the "bug" tag, since I don't see why this is an actual bug -- certainly nothing you pointed out is in conflict with my intention in coding it.
Namely 3:
I do not understand what does the first one do. The second one is very clear because it is not just abstract "Cancel". The one on the bottom is very confusing when the payment details are not open - it looks like "Cancel this pending payment". It seems to me that the bottom two buttons Cancel/OK have exactly the same function and the same effect is achieved by clicking on X in the top right corner or just outside the modal. I would get rid of them completely to avoid confusion.
Not sure what should be done about the first Cancel - either renamed to make it clear or eliminate if it is not necessary.
The text was updated successfully, but these errors were encountered: