Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Too many Cancel buttons #8064

Open
novoselt opened this issue Dec 16, 2024 · 1 comment
Open

Too many Cancel buttons #8064

novoselt opened this issue Dec 16, 2024 · 1 comment

Comments

@novoselt
Copy link
Collaborator

Namely 3:
image
I do not understand what does the first one do. The second one is very clear because it is not just abstract "Cancel". The one on the bottom is very confusing when the payment details are not open - it looks like "Cancel this pending payment". It seems to me that the bottom two buttons Cancel/OK have exactly the same function and the same effect is achieved by clicking on X in the top right corner or just outside the modal. I would get rid of them completely to avoid confusion.

Not sure what should be done about the first Cancel - either renamed to make it clear or eliminate if it is not necessary.

@williamstein
Copy link
Contributor

Not sure what should be done about the first Cancel - either renamed to make it clear or eliminate if it is not necessary.

This component is used in probably 10 different places. If we remove that cancel button, there may be places where people get frustratingly stuck and/or have to refresh their browser or something else.

image

The above are just for the overall balance modal. They have nothing to do with the payments component.

This ticket is too vague and I'm very reluctant to make ANY of the changes suggested here without significantly more discussion and thought, as they all have the potential to cause subtle bugs at a distance and/or just directly conflict with the overall design decisions of Antd (e.g., all modals have a footer with Cancel/OK by default). I'm also removing the "bug" tag, since I don't see why this is an actual bug -- certainly nothing you pointed out is in conflict with my intention in coding it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants