Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

stop seeing warning about firefox #1650

Closed
DrXyzzy opened this issue Feb 7, 2017 · 11 comments
Closed

stop seeing warning about firefox #1650

DrXyzzy opened this issue Feb 7, 2017 · 11 comments

Comments

@DrXyzzy
Copy link
Contributor

DrXyzzy commented Feb 7, 2017

Every time I refresh SMC in Firefox I see the same warning about performance issues "There are major performance issues with Firefox ..." and I have to click to dismiss it. How about a button in the warning that says Don't show this warning again?

@williamstein
Copy link
Contributor

  1. How bad are the performance issues now?

  2. Have you tested the "nightly betas" of firefox -- the claim to have totally fixed the problems there.

@DrXyzzy
Copy link
Contributor Author

DrXyzzy commented Feb 7, 2017

I haven't been testing nightly FF betas. The only issue I see consistently these days that I think is FF specific is left edit pane doesn't scroll down all the way with mouse with .md and .tex files. Workaround is to use arrow keys to move cursor down. As I recall, there were occasional 100% CPU spins attributed to FF, but I haven't seen one of those for a few weeks.

@williamstein
Copy link
Contributor

There is a ticket with a way to replicate the 100% cpu spins. If it is gone... we can just remove this message. It sounds like it is gone.

@DrXyzzy
Copy link
Contributor Author

DrXyzzy commented Feb 8, 2017

CPU spins seem to be mentioned at #1314. I just tested the snippet listed there on Linux and OS X Firefox and saw a CPU load spike with each, but neither had a stuck process, details at #1314. Based on that and my past few weeks' experience without CPU spin, I recommend removing the message.

@DrXyzzy
Copy link
Contributor Author

DrXyzzy commented Feb 8, 2017

Hardly any CPU spike running latest Firefox Nightly build on OS X and Ubuntu, see #1314.

@DrXyzzy DrXyzzy self-assigned this Feb 11, 2017
@DrXyzzy
Copy link
Contributor Author

DrXyzzy commented Feb 11, 2017

Let's keep this open until the fix in Nightly makes it into a Firefox release, then remove the warning.

@timothyclemansinsea
Copy link
Contributor

Wouldn't we want the warning to appear for older versions of Firefox?

@DrXyzzy
Copy link
Contributor Author

DrXyzzy commented Feb 13, 2017

Or change the warning on older versions of firefox to recommend upgrading.

@DrXyzzy
Copy link
Contributor Author

DrXyzzy commented Feb 13, 2017

Blocked, waiting for firefox release.

@DrXyzzy
Copy link
Contributor Author

DrXyzzy commented Feb 13, 2017

Oh, and there is one more issue with FF. SMC won't let you open a jupyter notebook from firefox because of truncation, issue #1537

@williamstein
Copy link
Contributor

I'm removing the message and closing.

I don't want to mess with complicated (possibly brittle) code for detecting old versions -- there's a ton that can go wrong with each older version, with no end in site. Users not using the latest version are not supported.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants