Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include information about the dark mode setting of the web interface #375

Open
schmanu opened this issue Oct 5, 2022 · 1 comment
Open
Labels
enhancement New feature or request

Comments

@schmanu
Copy link
Member

schmanu commented Oct 5, 2022

What problem does it solve?

Currently safe-apps cannot retrieve the information if the web interface has the dark mode enabled.
Therefore many safe apps only offer a light mode which does not look consistent with the web interface if dark mode is enabled.

How do we solve it?

We should add the information if the dark mode is enabled or not into the data the safe-apps-sdk retrieves from the web-core communicator. We could create a new data structure "settings" which for now only holds the info if the dark mode is enabled.

Then safe apps could react to that setting and change the theme accordingly.

@schmanu schmanu added the enhancement New feature or request label Oct 5, 2022
@github-project-automation github-project-automation bot moved this to New issues in Web Squad Feb 27, 2023
@katspaugh
Copy link
Member

@dasanra @mikhailxyz do you mind if we tackle this? @schmanu is eager.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Status: New issues
Development

No branches or pull requests

2 participants