Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

throw an error when trying to perform write operations with the safe in read-only mode #353

Open
mmv08 opened this issue Aug 2, 2022 · 0 comments
Open

throw an error when trying to perform write operations with the safe in read-only mode #353

mmv08 opened this issue Aug 2, 2022 · 0 comments

Comments

@mmv08
Copy link
Member

mmv08 commented Aug 2, 2022 •
edited
Loading

The CowSwap team is having an issue where clicking "swap" using a Safe in read-only mode does never resolve resulting in a bad UX: #301

I believe the core issue here is that we never resolve/reject the promise if the safe is in read-only mode. We should investigate and return an error in this case

Such operations are:

  • signing
  • transactions
  • requesting permissions
@mmv08 mmv08 changed the title throw an error when trying to perform write operations with the sdk throw an error when trying to perform write operations with the safe in read-only mode Aug 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@mmv08