fix: prevent RangeError in updatePressure #21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The for loop in which
updatePressure(i, pressure)is called is iterating overpts. When a stroke consists of only two points, additional points are added topts, soptshas more points thanpointsandupdatePressure(), which updatespoints, is called for points that don't exist. This results in errors likeAnother exception was thrown: RangeError (length): Invalid value: Not in inclusive range 0..1: 4.This commit fixes this behavior by changing the point that is updated in the for loop to the second point, if the stroke is consisting of exactly two points and
iis larger than 1.This fix is needed to fix saber-notes/saber#1391.