Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[GOFLOW-28] abstract the queue mechanism to support other mechanisms. #28

Open
giorgiozoppi opened this issue Nov 19, 2022 · 8 comments
Labels
enhancement New feature or request experimental

Comments

@giorgiozoppi
Copy link
Collaborator

giorgiozoppi commented Nov 19, 2022

Goflow Queue Abstraction.

Goal

We want to support multi distributed queue support other then a Redis:

  • support for RedPanda
  • support for RabbitMQ

So we might want to abstract the queue mechanism of this workflow manager to allow this extensibility.

@jippi
Copy link

jippi commented Dec 31, 2022

I would love an in memory/non-distributed mechanism :)

@s8sg
Copy link
Owner

s8sg commented Mar 11, 2023

@giorgiozoppi @jippi This has been requested by many. I think we can have the vanilla version using reds, with some customization option to support the queue.

For a quick start we definitely doesn't want users to configure a brunch of stuff

@giorgiozoppi
Copy link
Collaborator Author

Assign to me. I will work on this item.
queuestorage
This is an high level design.

@giorgiozoppi giorgiozoppi changed the title abstract the queue mechanism to support other mechanisms. [GOFLOW-28] abstract the queue mechanism to support other mechanisms. Mar 11, 2023
@giorgiozoppi
Copy link
Collaborator Author

For in memory queue i'd like to use rocksdb or similar things in go.

@s8sg
Copy link
Owner

s8sg commented Mar 11, 2023

@giorgiozoppi From project POV I'll put this in low priority. I'll focus on fix the existing issue and the bugs first. Once we have adaptability we can work on additional feature. WDYT ?

@s8sg s8sg added enhancement New feature or request experimental labels Mar 11, 2023
@s8sg
Copy link
Owner

s8sg commented Mar 11, 2023

@giorgiozoppi Why we need a in memory queue, redis is in memory. Are we saying we don't need distributed approach ?

@giorgiozoppi
Copy link
Collaborator Author

giorgiozoppi commented Mar 11, 2023

We don't need a memory queue. My answer is was to @jippi request. So please assign me some starting bug to fix, how can i help?. Looking to the code we just need an adapter to make different stores to be used.

@s8sg
Copy link
Owner

s8sg commented Mar 11, 2023 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request experimental
Projects
None yet
Development

No branches or pull requests

3 participants