Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

?dstrfw should be more upfront about the use of col_types names #32

Open
MichaelChirico opened this issue Feb 23, 2017 · 0 comments
Open

Comments

@MichaelChirico
Copy link

By complete accident doing some debugging, I realized that (despite my having read the argument list in ?dstrfw several times), contrary to what I had been doing, dstrfw provides functionality to handle input column names directly (rather than fixing up ex-post).

I only saw this because I was reading the source code of the function -- it took very careful poring over every word of the rest of ?dstrfw to find the morsel at the end of the Value section which states this feature.

It's a great feature, so it should get higher prominence! In particular it should definitely get mention in the col_types argument explanation.

I'm happy to submit a PR to this end.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant