Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: fixed the issue of blue underline between hyperlinks & added some examples #300

Merged
merged 3 commits into from
Sep 25, 2024

Conversation

Octopus058
Copy link
Contributor

  1. The reason for the blue underline between hyperlinks is that thetag in HTML automatically generates a blue underline, and adjacent hyperlinks are automatically connected. The solution is to use markdown to insert images.
  2. Rearranged small tags such as star and forks in logical order.
  3. Added several example images.
  4. Fixed some statement and format errors.

Copy link

vercel bot commented Sep 24, 2024

@Octopus058 is attempting to deploy a commit to the ryo-ma's Team Team on Vercel.

A member of the Team first needs to authorize it.

@ryo-ma
Copy link
Owner

ryo-ma commented Sep 24, 2024

The reason for the blue underline between hyperlinks is that thetag in HTML automatically generates a blue underline, and adjacent hyperlinks are automatically connected. The solution is to use markdown to insert images.

The centering has come off.

@Octopus058
Copy link
Contributor Author

The reason for the blue underline between hyperlinks is that thetag in HTML automatically generates a blue underline, and adjacent hyperlinks are automatically connected. The solution is to use markdown to insert images.

The centering has come off.

hmmm I don't understand what you meant.

@ryo-ma
Copy link
Owner

ryo-ma commented Sep 25, 2024

スクリーンショット 2024-09-25 10 47 58 This is the diff in your PR. The images are aligned to the left, so I would like to center them.

@ryo-ma
Copy link
Owner

ryo-ma commented Sep 25, 2024

It was my mistake in checking.
I checked the file instead of diff and there was no problem.

@ryo-ma
Copy link
Owner

ryo-ma commented Sep 25, 2024

However, CI is failing.
Can you run the deno fmt?

https://github.com/ryo-ma/github-profile-trophy/actions/runs/11016403533/job/30591819089?pr=300

@Octopus058
Copy link
Contributor Author

Octopus058 commented Sep 25, 2024

How?
Screenshot_2024-09-25-09-51-24-033_com.github.android.jpg

Screenshot_2024-09-25-09-51-58-415_com.github.android.jpg

They are pretty fine in my view. and you can see they are just in the block of "div align="center"", so it shouldn't happen, weird :(

@ryo-ma
Copy link
Owner

ryo-ma commented Sep 25, 2024

The above was a misunderstanding on my part.
However, Formatter's CI is failing.
https://github.com/ryo-ma/github-profile-trophy/actions/runs/11016403533/job/30591819089?pr=300

Please run the deno fmt command to fix it.

@Octopus058
Copy link
Contributor Author

The above was a misunderstanding on my part.
However, Formatter's CI is failing.
https://github.com/ryo-ma/github-profile-trophy/actions/runs/11016403533/job/30591819089?pr=300

Please run the deno fmt command to fix it.

I'm too busy to fix it now, but I'll make it as soon as possible xD

Copy link
Contributor Author

@Octopus058 Octopus058 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Alright now 👍

@ryo-ma ryo-ma merged commit 87376e5 into ryo-ma:master Sep 25, 2024
1 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants