Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unify format of descriptor maps (or not) #15

Open
perellonieto opened this issue Sep 20, 2019 · 1 comment
Open

Unify format of descriptor maps (or not) #15

perellonieto opened this issue Sep 20, 2019 · 1 comment
Assignees
Labels
enhancement New feature or request question Further information is requested

Comments

@perellonieto
Copy link
Collaborator

The localisation and activity examples use different format of descriptor_map

eg. The localisation uses arrays of integers denoting the labels

descriptor_map = {
'foyer' : [0],
'bedroom' : [1],
'living_room' : [2],
'bathroom' : [3]
}

While the accelerometer example uses integers

descriptor_map = {
'sitting' : 77,
'walking' : 78,
'washing' : 79,
'eating' : 80,
'sleeping': 81,
'studying': 82
}

What is the reasoning behind it, and which method should we choose as standard. A benefit from the list is that it could group labels, for example "upstairs" could be associated to [0, 1, 2], or "sedentary" as well.

I am not sure if there are collateral implications on this modification.

@perellonieto perellonieto added enhancement New feature or request question Further information is requested labels Sep 20, 2019
@rymc
Copy link
Owner

rymc commented Sep 20, 2019

I quite like the idea of a list. It is little less clear in terms of an accelerometer - but the added flexibility may be useful if you want to, for example, group running, swimming, frisbee, basketball all as 'exercise'.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request question Further information is requested
Projects
None yet
Development

No branches or pull requests

3 participants