Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Label mappings returns different structures depending on a csv being specified #14

Open
perellonieto opened this issue Sep 19, 2019 · 2 comments
Assignees
Labels
question Further information is requested

Comments

@perellonieto
Copy link
Collaborator

perellonieto commented Sep 19, 2019

Both functions label_mappings and label_mappings_localisation return different formats depending on a CSV being specified during the instantiation of a Wrapper. I would opt to return always the same format, and convert it to the required format if necessary while exporting the CSV file, however, I am not familiar with the code and I am not sure which would be the more generic format, and the implications that this may have.

@mkoz71 could you help me with this decision?

Also, this may be related to the issue #13

def label_mappings(self, container, is_duration, label_to_extract=None):

@perellonieto perellonieto added the question Further information is requested label Sep 19, 2019
@perellonieto perellonieto self-assigned this Sep 19, 2019
@mkoz71
Copy link
Collaborator

mkoz71 commented Sep 20, 2019

Hi Miquel,

You are right. This particular function I wrote quickly to incorporate the csv saving functionality. What you are saying makes more sense.

So long as you check that the csv is specified AND you change the format accordingly, the code should still run without issues.

Michal

@perellonieto
Copy link
Collaborator Author

I modified the code to return always the dictionaries with the specified values, this needs to be then modified while exporting the csv files.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question Further information is requested
Projects
None yet
Development

No branches or pull requests

2 participants