Add AbstractRange and StaticRange interfaces
#4221
Open
+253
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
behrenle
force-pushed
the
add-static-range-interface
branch
from
c73ef02
to
2298ee6
Compare
daxpedda
requested changes
Nov 9, 2024
Comment on lines
+14
to
+21
| [Throws] | ||
| readonly attribute Node startContainer; | ||
| [Throws] | ||
| readonly attribute unsigned long startOffset; | ||
| [Throws] | ||
| readonly attribute Node endContainer; | ||
| [Throws] | ||
| readonly attribute unsigned long endOffset; |
There was a problem hiding this comment.
I can't find anything in the specification saying that this could throw.
I assume you simply copied this from the Firefox webidl directory, but we tend to follow the specification as close as possible.
Let me know if you have different information.
| @@ -10,10 +10,10 @@ | |||
| * | |||
| * Copyright © 2012 W3C® (MIT, ERCIM, Keio), All Rights Reserved. W3C | |||
| * liability, trademark and document use rules apply. | |||
| */ | |||
| */ | |||
|
|
||
| [Exposed=Window] | ||
| interface StaticRange : AbstractRange { | ||
| constructor(StaticRangeInit init); |
There was a problem hiding this comment.
Suggested change
| constructor(StaticRangeInit init); | |
| [Throws] constructor(StaticRangeInit init); |
Constructors are marked as throwing by default, but just in case we want to change this in the future.
Comment on lines
+17
to
+21
| * Added bindings for `StaticRange`. | ||
| [#4221](https://github.com/rustwasm/wasm-bindgen/pull/4221) | ||
|
|
||
| * Added bindings for `AbstractRange`. | ||
| [#4221](https://github.com/rustwasm/wasm-bindgen/pull/4221) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request adds support for the
AbstractRangeandStaticRangeinterfaces to wasm-bindgen, enabling Rust developers to interact with these DOM range objects for improved web API compatibility.