Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow SharedArrayBuffer to be passed to DataView constructor #3695

Merged
merged 5 commits into from
Nov 10, 2023
Merged

Allow SharedArrayBuffer to be passed to DataView constructor #3695

merged 5 commits into from
Nov 10, 2023

Conversation

kyledecot
Copy link
Contributor

@kyledecot kyledecot commented Nov 9, 2023 •
edited
Loading

@kyledecot kyledecot marked this pull request as ready for review November 9, 2023 13:57
daxpedda
daxpedda requested changes Nov 9, 2023
View reviewed changes
crates/js-sys/src/lib.rs Outdated Show resolved Hide resolved
@kyledecot kyledecot requested a review from daxpedda November 9, 2023 21:59
daxpedda
daxpedda requested changes Nov 9, 2023
View reviewed changes
Copy link
Collaborator

@daxpedda daxpedda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One last thing, apologies, I keep forgetting that:
could you add an entry in the changelog?

@kyledecot kyledecot requested a review from daxpedda November 10, 2023 14:07
daxpedda
daxpedda reviewed Nov 10, 2023
View reviewed changes
CHANGELOG.md Outdated Show resolved Hide resolved
daxpedda
daxpedda approved these changes Nov 10, 2023
View reviewed changes
Copy link
Collaborator

@daxpedda daxpedda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@daxpedda daxpedda merged commit 54e0aa6 into rustwasm:main Nov 10, 2023
23 checks passed
@kyledecot kyledecot deleted the data-view branch November 10, 2023 14:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@daxpedda daxpedda daxpedda approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support Passing a SharedArrayBuffer to DataView
2 participants
@kyledecot @daxpedda