Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix ambiguous associated type error when enum has variant called Error #3678

Merged
merged 3 commits into from
Nov 2, 2023
Merged

Fix ambiguous associated type error when enum has variant called Error #3678

merged 3 commits into from
Nov 2, 2023

Conversation

mlwilkerson
Copy link
Contributor

Closes #3677

daxpedda
daxpedda approved these changes Nov 2, 2023
View reviewed changes
Copy link
Collaborator

@daxpedda daxpedda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@Liamolucko could you take a look at this again?

@daxpedda daxpedda added the needs review Needs a review by a maintainer. label Nov 2, 2023
Liamolucko
Liamolucko approved these changes Nov 2, 2023
View reviewed changes
Copy link
Collaborator

@Liamolucko Liamolucko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@Liamolucko Liamolucko merged commit 962f580 into rustwasm:main Nov 2, 2023
25 checks passed
@Liamolucko Liamolucko mentioned this pull request Nov 20, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Liamolucko Liamolucko Liamolucko approved these changes

@daxpedda daxpedda daxpedda approved these changes

Assignees
No one assigned
Labels
needs review Needs a review by a maintainer.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

compilation failure with ambiguous associated item when enum has variant called Error
3 participants
@mlwilkerson @daxpedda @Liamolucko