guide: add missing and fix incorrect testing info #3629
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
in the contributing section. Some tests need `WASM_BINDGEN_SPLIT_LINKED_MODULES` set to run through, and the macro ui-tests are not a workspace package anymore Signed-off-by: Dominik Csapak <[email protected]>
|
i did not really find instructions to build the guide book, so i could not verify if the formatting, etc. is ok |
Liamolucko
reviewed
Sep 21, 2023
guide/src/contributing/testing.md
Outdated
Comment on lines
40
to
41
| cd crates/macro | ||
| cargo test |
There was a problem hiding this comment.
You can do this more concisely with cargo test -p wasm-bindgen-macro.
There was a problem hiding this comment.
ah yes, i missed that. was only looking at the members in the workspace, i'll push a commit shortly
by using `-p wasm-bindgen-macro` instead of changing dir to `crates/macro` Signed-off-by: Dominik Csapak <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
in the contributing section.
Some tests need
WASM_BINDGEN_SPLIT_LINKED_MODULESset to run through, and the macro ui-tests are not a workspace package anymore