Skip to content

Commit

Permalink
Allow SharedArrayBuffer to be passed to DataView constructor (#3695)
Browse files Browse the repository at this point in the history
  • Loading branch information
kyledecot authored Nov 10, 2023
1 parent f7fdb2f commit 54e0aa6
Show file tree
Hide file tree
Showing 2 changed files with 19 additions and 0 deletions.
7 changes: 7 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,6 +1,13 @@
# `wasm-bindgen` Change Log
--------------------------------------------------------------------------------

## [Unreleased](https://github.com/rustwasm/wasm-bindgen/compare/0.2.88...main)

### Added

* Add additional constructor to `DataView` for `SharedArrayBuffer`.
[#3695](https://github.com/rustwasm/wasm-bindgen/pull/3695)

## [0.2.88](https://github.com/rustwasm/wasm-bindgen/compare/0.2.87...0.2.88)

Released 2023-11-01
Expand Down
12 changes: 12 additions & 0 deletions crates/js-sys/src/lib.rs
Original file line number Diff line number Diff line change
Expand Up @@ -1598,6 +1598,18 @@ extern "C" {
#[wasm_bindgen(constructor)]
pub fn new(buffer: &ArrayBuffer, byteOffset: usize, byteLength: usize) -> DataView;

/// The `DataView` view provides a low-level interface for reading and
/// writing multiple number types in an `ArrayBuffer` irrespective of the
/// platform's endianness.
///
/// [MDN documentation](https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/DataView)
#[wasm_bindgen(constructor)]
pub fn new_with_shared_array_buffer(
buffer: &SharedArrayBuffer,
byteOffset: usize,
byteLength: usize,
) -> DataView;

/// The ArrayBuffer referenced by this view. Fixed at construction time and thus read only.
///
/// [MDN documentation](https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/DataView/buffer)
Expand Down

0 comments on commit 54e0aa6

Please sign in to comment.