Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add remaining CI improvements #194

Closed
6 tasks done
josephlr opened this issue Jan 4, 2021 · 1 comment
Closed
6 tasks done

Add remaining CI improvements #194

josephlr opened this issue Jan 4, 2021 · 1 comment
Assignees
@josephlr
Labels
testing waiting on upstream Waiting for upstream changes in an external project

Comments

@josephlr
Copy link
Member

josephlr commented Jan 4, 2021 •
edited
Loading

After #192, we still have a few things we should add to our CI. These include:
@josephlr josephlr mentioned this issue Jan 4, 2021
Merged
@josephlr josephlr self-assigned this Jan 4, 2021
@josephlr josephlr added good first issue Good for newcomers help wanted Extra attention is needed labels Jan 4, 2021
@josephlr josephlr mentioned this issue Jan 5, 2021
Merged
josephlr added a commit that referenced this issue Jan 5, 2021
@josephlr
Add Emscripten tests (#196)
9d7a76c 
See #194 

This installs (and caches) the emsdk toolchain at the last version compatible w/ stable rust. It also tests on both asmjs and wasm32, uses node by default, and works around an asm.js bug.
@josephlr josephlr mentioned this issue Jan 5, 2021
Merged
josephlr added a commit that referenced this issue Jan 5, 2021
@josephlr
Add test for custom RNG handler (#197)
347a300 
See #194

This uses the fact that `wasm32-unknown-unknown` is an "unsupported" target. This means we can use the `"custom"` feature to define a custom handler, and then write tests to make sure that function is called.
@josephlr josephlr added testing and removed good first issue Good for newcomers labels Oct 23, 2022
@josephlr josephlr mentioned this issue Oct 24, 2022
Merged
@josephlr josephlr added waiting on upstream Waiting for upstream changes in an external project and removed help wanted Extra attention is needed labels Oct 24, 2022
@josephlr
Copy link
Member Author

With #316 the only think we are waiting on is AArch64 macOS runners. This is tracked in github/roadmap#528

@josephlr josephlr mentioned this issue Feb 21, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@josephlr josephlr

Labels
testing waiting on upstream Waiting for upstream changes in an external project
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@josephlr