Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support ndarray 0.16 #357

Open
joelchen opened this issue Aug 8, 2024 · 7 comments
Open

Support ndarray 0.16 #357

joelchen opened this issue Aug 8, 2024 · 7 comments

Comments

@joelchen
Copy link

joelchen commented Aug 8, 2024

If project uses ndarray 0.16, the following error occurs when initializing DatasetBase:

the trait `Records` is not implemented for `ArrayBase<OwnedRepr<f64>, Dim<[usize; 2]>>`
@altunenes
Copy link

any hope for support 0.16?

@infosechoudini
Copy link

if you clone the repo, just bump up ndarray to "0.16" and linfa-linalg = "0.2". that's how i got this to work

@joelchen
Copy link
Author

@YuhanLiin Noticed you have recently updated linfa-linalg to 0.2. Will updating linfa's ndarray to 0.16 break anything? If not, can you submit a pull request to update ndarray to 0.16?

@infosechoudini
Copy link

It does break some stuff, i had to update linfa to ndarray and then update ndarray-csv (on my github). linfa-linalg to v0.2 and ndarray-linalg are mutually exclusive, so i had to make changes there too. It's quite involved, easy code changes but many locations.

@YuhanLiin
Copy link
Collaborator

I no longer maintain Linfa, but if someone uploads a PR for bumping ndarray I can review and merge it.

@infosechoudini
Copy link

Does anyone maintain Linfa?

@Mountagha
Copy link

I might be interested in giving it a look if nobody is working on it. @infosechoudini @YuhanLiin

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants