Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tracking issue: react-ification #128

Closed
10 of 14 tasks
nrc opened this issue Mar 28, 2017 · 3 comments
Closed
10 of 14 tasks

Tracking issue: react-ification #128

nrc opened this issue Mar 28, 2017 · 3 comments

Comments

@nrc
Copy link
Member

nrc commented Mar 28, 2017

Convert to using React

  • Errors and build results
  • error explanations
  • build animation
  • buttons/menus/search box in top bar
  • menus
  • breadcrumbs
  • source view (including highlights)
  • directory view
  • search results (search and find)
  • summary/docs
  • history/state/back button use/return to build results
  • URLs
  • improve workflow (e.g., Use webpack to create a module as output #126)
  • optimise (seems to be dog slow atm)
@nrc
Copy link
Member Author

nrc commented May 14, 2017

Refactorings for when initial work is done:

  • move some exports from rustw.js to utils.js
  • split components into presentational and container kinds
  • general tidying up/factoring out common functionality
  • smaller components - e.g., overlay for menu, etc.
  • TODOs

@AlexPikalov
Copy link
Contributor

AlexPikalov commented Jul 20, 2017

@nrc any plans to rid of jquery?

Maybe I'm missing something, but as far as I can see it's used just for DOM manipulations + ajax call. DOM manipulations should be done by React. As for ajax calls, for me it makes sense to use some of fetch polyfills such as https://github.com/matthew-andrews/isomorphic-fetch. Which is pretty wide used in React applications.

Also I didn't find any other dependencies you use which would depend on jquery.

@nrc
Copy link
Member Author

nrc commented Jul 20, 2017

any plans to rid of jquery?

I would like to do this, and I've been removing bits as I go, but it has not been high priority. It would be great to remove the dependency. I'm not sure what is left, I don't think there are that many DOM interactions, and probably nothing that can't be replaced with native equivalents or React. I'd be happy to use fetch natively - I don't think we need to accommodate people on older browsers. Alternatively, we could use XMLHttpRequest - I don't think it is much harder than $ajax (I would like to avoid adding another dep).

@nrc nrc closed this as completed Mar 21, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants