Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add graceful shutdown to ServiceAsTool's start_consuming_callable task. #147

Open
nerdai opened this issue Jul 20, 2024 · 0 comments
Open

Add graceful shutdown to ServiceAsTool's start_consuming_callable task. #147

nerdai opened this issue Jul 20, 2024 · 0 comments
Labels
enhancement New feature or request P1

Comments

@nerdai
Copy link
Contributor

nerdai commented Jul 20, 2024

When acall is invoked for ServiceAsTool's it may register to the message queue and send the returned start_consuming_callable task in the "background" via asyncio.create_task.

When shutting down a system with such a service, we don't currently cancel this task.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request P1
Projects
No open projects
llama-agents
Status: Todo
Milestone
No milestone
Development

No branches or pull requests
2 participants
@logan-markewich @nerdai