135M mini_racer-0.6.2

[chrishough]

Why is this gem so large? It has started to cause my heroku slug deploys to break because it is pushing me over the limit. Is there. away to reduce this?

[SamSaffron]

libv8.a is quite bit ~30 megs I think and it is included twice due to Ruby gems shenanigans we can probably remove one copy ... but get this much smaller than that... no ... it is basically the size of google chrome.

will investigate ...

[chrishough]

If we can remove it once, that would be awesome, so there is only one copy of it 👍

[SamSaffron]

note libv8_monolith.a is 117. MiB so there is that as well.

Long term plan is for everything to be self contained.

[chrishough]

Right now I am using this to purge what I can from the advice of the team at DataDog, and a lot of reading online...

namespace :heroku do
  desc "Cleans up unnecessary cached files from gems installed via bundler"
  task clean_gem_artifacts: :environment do
    puts "\n*************************************\n"
    puts "Cleaning up SASSC Artifacts"
    Bundler.bundle_path.glob( "**/ext/**/*.o" ).each( &:delete )
    puts "Cleaning up Gem Artifacts"
    # rubocop:disable Layout/SpaceInsideParens
    system(`find $(bundle show libv8-node) \\( -name '*.a' \\) -exec rm {} \\;`)
    # rubocop:enable Layout/SpaceInsideParens
    puts "\n*************************************\n"
  end
end

if Rake::Task.task_defined?( "assets:clean" )
  Rake::Task[ "assets:clean" ].enhance [ "heroku:clean_gem_artifacts" ]
else
  Rake::Task.define_task( "assets:clean" => "heroku:clean_gem_artifacts" )
end

[nightpool]

find $(bundle show libv8-node) \( -name '*.a' \) -exec rm {} \;

Wouldn't this just delete V8 entirely, making MiniRacer completely inoperable? Why not just remove the gem in that case?

[chrishough]

@nightpool according to the DataDog team, those are not required, also our tests showed that was the case.

[SamSaffron]

I may be wrong, but I think upgrades to mini racer will stop working if you remove the file and the upgrade does not change the version of libv8

…

On Sat, 5 Feb 2022 at 7:11 am, Chris Hough ***@***.***> wrote: @nightpool <https://github.com/nightpool> according to the DataDog team, those are not required, also our tests showed that was the case. — Reply to this email directly, view it on GitHub <#235 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAABIXN2RQ2M3J7BCB6GECTUZQXFXANCNFSM5NNT4V4Q> . Triage notifications on the go with GitHub Mobile for iOS <https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675> or Android <https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>. You are receiving this because you commented.Message ID: ***@***.***>

[chrishough]

[bisrael]

Not sure if it helps, but in our production install of 0.6.2, seeing 2 copies of mini_racer_extension.so as reported by du

remote: MINIRACER:
remote: 68M /tmp/build_137e1580/vendor/bundle/ruby/2.7.0/gems/mini_racer-0.6.2/lib/mini_racer_extension.so
remote: 68M /tmp/build_137e1580/vendor/bundle/ruby/2.7.0/gems/mini_racer-0.6.2/lib
remote: 68M /tmp/build_137e1580/vendor/bundle/ruby/2.7.0/gems/mini_racer-0.6.2/ext/mini_racer_extension/mini_racer_extension.so
remote: 69M /tmp/build_137e1580/vendor/bundle/ruby/2.7.0/gems/mini_racer-0.6.2/ext/mini_racer_extension
remote: 69M /tmp/build_137e1580/vendor/bundle/ruby/2.7.0/gems/mini_racer-0.6.2/ext
remote: 136M /tmp/build_137e1580/vendor/bundle/ruby/2.7.0/gems/mini_racer-0.6.2

dunno if that's a symlink or something?

[tisba]

@bisrael: I cannot reproduce this (neither with 0.6.2 nor with 0.6.4):

$ gem install mini_racer -v 0.6.4
# …
8.0K    ./bin
 80K    ./ext/mini_racer_extension
 20K    ./ext/mini_racer_loader
100K    ./ext
4.0K    ./.github/workflows
4.0K    ./.github
 16K    ./lib/mini_racer
 59M    ./lib
 59M    .

[tisba]

Removing the libv8_monolith.a from lib8-node gem will work. Until you try to update mini_racer and hence have to compile the new version against libv8-node. The only use case I can currently think of is when building Dockage container images.

I'm a little hesitant adding a hint to the README, because there are already quite a few issues from users with installation problems and I don't like to add potential for more cases…