Fix for proxied array barfing #17
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Added specs for serializing arrays which are transparently proxied through another class. - Added check to native ext to convert an T_OBJECT to a T_ARRAY if possible, and leave it alone otherwise. - Updated Rakefile to work with latest (10.0.4)
|
This would be a useful one to merge. Please look at this one. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
another class.
possible, and leave it alone otherwise.
Let me know if you think this should be done differently. This solution is working for me. By the way thanks for your work getting AMF into C. My app is SO much faster with it.