Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ATK_HIT_ABS params missing accessor calls #11

Open
buhao8 opened this issue Aug 20, 2020 · 0 comments
Open

ATK_HIT_ABS params missing accessor calls #11

buhao8 opened this issue Aug 20, 2020 · 0 comments

Comments

@buhao8
Copy link

buhao8 commented Aug 20, 2020

Currently, the last 3 parameters of ATK_HIT_ABS are displayed incorrectly (most notable occurrences are in throws).

Here's an example of it:

ATK_HIT_ABS(FIGHTER_ATTACK_ABSOLUTE_KIND_THROW,
            hash40("throw"),
            FIGHTER_STATUS_THROW_WORK_INT_TARGET_OBJECT,
            FIGHTER_STATUS_THROW_WORK_INT_TARGET_HIT_GROUP,
            FIGHTER_STATUS_THROW_WORK_INT_TARGET_HIT_NO)

The last 3 arguments should be passed through WorkModule::get_int64 like so:

ATK_HIT_ABS(FIGHTER_ATTACK_ABSOLUTE_KIND_THROW,
            hash40("throw"), 
            WorkModule::get_int64(module_accessor, FIGHTER_STATUS_THROW_WORK_INT_TARGET_OBJECT), 
            WorkModule::get_int64(module_accessor, FIGHTER_STATUS_THROW_WORK_INT_TARGET_HIT_GROUP), 
            WorkModule::get_int64(module_accessor, FIGHTER_STATUS_THROW_WORK_INT_TARGET_HIT_NO))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant