Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support for all official Property types + much much more. #12

Open
wants to merge 19 commits into
base: master
Choose a base branch
from
Open

Support for all official Property types + much much more. #12

wants to merge 19 commits into from

Conversation

Tuupertunut
Copy link

@Tuupertunut Tuupertunut commented Jul 25, 2017 •
edited
Loading

Major changes:

  • Support for ObjectProperty, ListProperty, SetProperty and MapProperty
    • Their generics are working too.
  • Support for read-only properties.
    • Like writable properties, but without setter.
  • Support for read-only wrappers.
    • Like read-only properties, but property getter returns the wrapped read-only property with getReadOnlyProperty().
  • Old methods don't get removed anymore. Instead, new methods just won't get created if there already is a method with that name.
    • This prevents code accidentally being deleted.

Minor changes:

  • Removed final from the xxxProperty() property getter methods.
  • Moved getters first, before setters and property getters.
    • They appear to be so in most of JavaFX documentation.
  • The generation action now appears only if the class has property fields.
  • Plugin moved to the same JavaFX 2 category as the official JavaFX plugins.
  • Now requires at least NetBeans 8.1.

Development-only changes:

  • Removed nb-configuration.xml from project.
    • Its jdkPlatform property is causing compilation issues to many developers, including me.
    • It isnt needed anyway, as java version is already specified in the POM.
  • A LOT of refactoring.

Bugfixes:

  • Fixed NullPointerException when pressing Alt + Insert outside of a class.
  • Method generation now works in enums as well.
  • Methods are no longer generated for any class implementing Property
    • There is no way to know what types their values are and what methods they support. This caused invalid methods and errors.
    • Only the official Property classes are supported. List in readme.
  • First character capitalization for getter and setter names is no longer locale sensitive
    • For example, property idle used to create method getİdle in Turkish locale.

Tuupertunut added 19 commits July 21, 2017 05:21
@Tuupertunut
Removed nb-configuration.xml.
a67282a 
The jdkPlatform property is causing compiling issues for many developers and isn't needed anyway.
@Tuupertunut
Moved plugin to same category as other JavaFX plugins.
ca70cf9
@Tuupertunut
Run the code through reformatter.
48c13bf 
Apparently committer @kunstmusik used tabs for indentation while the rest of the code used 4 spaces. Everything uses 4 spaces now.
@Tuupertunut
Removed "final" modifier from property getters.
45e6dc5 
Property getter should not be final. See: https://wiki.openjdk.java.net/display/OpenJFX/JavaFX+Property+Architecture#JavaFXPropertyArchitecture-JavaFXSolution
@Tuupertunut
Refactored a few Booleans.
ad27666
@Tuupertunut
Added support for all writable property types.
411345c 
Support added for:
ObjectProperty
ListProperty
SetProperty
MapProperty

+ refactoring related to the changes.
@Tuupertunut
Moved getters first like they are in most documentation.
5f2642a
@Tuupertunut
Restricted method generation to only supported property classes.
f1c3e3d 
Previously all classes implementing "Property" were supported, which led to errors.
@Tuupertunut
Fixed toUpperCase being locale sensitive.
2ac35c2 
For example, previously in the Turkish locale, property "idle" would generate a method "getİdle" instead of "getIdle".
@Tuupertunut
Refactored code, no functional changes.
99b4ff2
@Tuupertunut
Removed unused methods.
743d1bd
@Tuupertunut
Old methods no longer get removed at generation.
772c1c6 
Instead, new methods check if there is already a method with the same name. If there is, the new method just won't get created. This ensures that no code will be accidentally removed. This is also how the NetBeans default "Getter and Setter..." generator works.
@Tuupertunut
Added support for read-only properties.
78de253
@Tuupertunut
Added support for read-only wrappers.
0c8663f
@Tuupertunut
Fixed generation not working in enum classes.
0164efa 
Uses a new method TreeUtilities.getPathElementOfKind, which was added in NetBeans 8.1. For this reason, all NetBeans dependencies are updated to 8.1.
@Tuupertunut
Fixed NullPointer when opening "Generate code" dialog outside of a cl…
edc858d 
…ass.
@Tuupertunut
Refactored code, no functional changes.
76c4a11
@Tuupertunut
Generator now appears only if class has property fields.
1ae18d5
@Tuupertunut
Updated readme.
f3f0274
@Tuupertunut
Copy link
Author

I have released these changes as a separate plugin in the plugin portal.

https://github.com/Tuupertunut/JavaFXGetterGenerator
http://plugins.netbeans.org/plugin/73209/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@Tuupertunut