Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Small issues with translatable strings #348

Open
webdados opened this issue Aug 14, 2024 · 0 comments · May be fixed by #349
Open

Small issues with translatable strings #348

webdados opened this issue Aug 14, 2024 · 0 comments · May be fixed by #349

Comments

@webdados
Copy link

While helping with the translation of this plugin to Portuguese, on a translation contribution meetup last night, we found some issues that need to be fixed.

  • The "NOTE: To enable the logging feature, you must define NGINX_HELPER_LOG constant as true in your wp-config.php" string for the "Enable Logging" option is confusing to translate, and it need to be refactored as a proper full sentence
  • Some strings have a trailing space as they are concatenated with dynamic values, making them incompatible with languages where the phrase structure might be different. For example: esc_attr__( 'Posted ', 'nginx-helper' ) . esc_attr( $item->get_date( 'j F Y | g:i a' ) )
@webdados webdados linked a pull request Aug 14, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant