-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
networkD3 package and progress bars #2329
Comments
alandipert
added a commit
that referenced
this issue
Mar 22, 2019
* All of these were caused by the presence of multiple body tags on the page, which happened because networkD3's sankey plot generates SVGs containing body tags via SVG's foreignObject tag * In various places, the 'body' jQuery selector string is used under the assumption there is only one 'body' tag on the page. The presence of multiple 'body' tags breaks reliant code in strange ways. * The fix in all cases was to make the body selector more specific: 'body:first' does the job.
@baczychris thank you for the report, I think I was able to identify a fix. |
alandipert
added a commit
that referenced
this issue
Mar 22, 2019
* All of these were caused by the presence of multiple body tags on the page, which happened because networkD3's sankey plot generates SVGs containing body tags via SVG's foreignObject tag * In various places, the 'body' jQuery selector string is used under the assumption there is only one 'body' tag on the page. The presence of multiple 'body' tags breaks reliant code in strange ways. * The fix was to use document.body or 'body:first' instead of 'body'.
I think we found a workaround for this on our end (see christophergandrud/networkD3#214), but I believe a fix here would be preferable... interested to see what fix you came up with. |
alandipert
added a commit
that referenced
this issue
Mar 27, 2019
* All of these were caused by the presence of multiple body tags on the page, which happened because networkD3's sankey plot generates SVGs containing body tags via SVG's foreignObject tag * In various places, the 'body' jQuery selector string is used under the assumption there is only one 'body' tag on the page. The presence of multiple 'body' tags breaks reliant code in strange ways. * The fix was to use document.body or 'body:first' instead of 'body'.
alandipert
added a commit
that referenced
this issue
Mar 27, 2019
* All of these were caused by the presence of multiple body tags on the page, which happened because networkD3's sankey plot generates SVGs containing body tags via SVG's foreignObject tag * In various places, the 'body' jQuery selector string is used under the assumption there is only one 'body' tag on the page. The presence of multiple 'body' tags breaks reliant code in strange ways. * The fix was to use document.body or 'body:first' instead of 'body'.
alandipert
added a commit
that referenced
this issue
Mar 27, 2019
* All of these were caused by the presence of multiple body tags on the page, which happened because networkD3's sankey plot generates SVGs containing body tags via SVG's foreignObject tag * In various places, the 'body' jQuery selector string is used under the assumption there is only one 'body' tag on the page. The presence of multiple 'body' tags breaks reliant code in strange ways. * The fix was to use document.body or 'body:first' instead of 'body'.
alandipert
added a commit
that referenced
this issue
Mar 27, 2019
* All of these were caused by the presence of multiple body tags on the page, which happened because networkD3's sankey plot generates SVGs containing body tags via SVG's foreignObject tag * In various places, the 'body' jQuery selector string is used under the assumption there is only one 'body' tag on the page. The presence of multiple 'body' tags breaks reliant code in strange ways. * The fix was to use document.body or 'body:first' instead of 'body'.
alandipert
added a commit
that referenced
this issue
Mar 27, 2019
* All of these were caused by the presence of multiple body tags on the page, which happened because networkD3's sankey plot generates SVGs containing body tags via SVG's foreignObject tag * In various places, the 'body' jQuery selector string is used under the assumption there is only one 'body' tag on the page. The presence of multiple 'body' tags breaks reliant code in strange ways. * The fix was to use document.body or 'body:first' instead of 'body'.
alandipert
added a commit
that referenced
this issue
Mar 27, 2019
* All of these were caused by the presence of multiple body tags on the page, which happened because networkD3's sankey plot generates SVGs containing body tags via SVG's foreignObject tag * In various places, the 'body' jQuery selector string is used under the assumption there is only one 'body' tag on the page. The presence of multiple 'body' tags breaks reliant code in strange ways. * The fix was to use document.body or 'body:first' instead of 'body'.
schloerke
added a commit
that referenced
this issue
Mar 27, 2019
* rc-v1.3.0: Remove reactlog from Remotes Fix #2349, #2329, #1817: bugs triggered by networkD3 sankey plot Improve bootstrap-datepicker update tools, add docs Add 'Fix datepicker DST bug' as patch Improve bootstrap-datepicker update script Re-import bootstrap-datepicker 1.6.4 Remove httpuv and reactlog from remotes Restore intuitive bookmarking behavior (#2360)
alandipert
added a commit
that referenced
this issue
May 8, 2019
This is finally fixed on master and should be available in the next Shiny release. Sorry for the delay. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Hi,
I have some issues with progress bars in Shiny and the package networkD3. If I try to use a progress bar and the networkD3 package, the bar shows up once but not in subsequent calls. But each time the slider is used the progess bar should appear, which is the case without the sankey diagram.
I tested in Chrome.
Here is a minimum example code:
In my use case I use several progress bars and none are displayed if I include the flow diagram.
Thanks, Christian
The text was updated successfully, but these errors were encountered: