New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Confirm is not a promise and can throw unhandled errors #17

Open

ilanolkies opened this issue Nov 10, 2021 · 0 comments

Labels

bug

Milestone

Contributor

ilanolkies commented Nov 10, 2021

      await request.confirm({

this should be awaited otherwise it will swallow some errors, but it breaks the tests so maybe it's better to deal with it in another PR

Originally posted by @chescalante in rsksmart/rif-wallet#54 (comment)

The text was updated successfully, but these errors were encountered:

ilanolkies added the bug label

ilanolkies added this to the v1.0.0 milestone

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment