Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Indentation should be handled statement-wise #6

Open
CodeFloh opened this issue Jun 1, 2016 · 1 comment
Open

Indentation should be handled statement-wise #6

CodeFloh opened this issue Jun 1, 2016 · 1 comment

Comments

@CodeFloh
Copy link
Collaborator

CodeFloh commented Jun 1, 2016

We are currently looking at code lines to determine indentation rules. This is not good, since we need to consider the full statement including continuation lines. Currently, this creates the following issues in the presence of multiline statements:

  • Keywords that increase indentation will sometimes not be recognized
  • Some continuation lines may not be recognized as strings and therefore parts of strings are falsely recognized as keywords
  • Indentation is increased too early (indentation change within multi-line statement instead of after)
@PaulOxxx1
Copy link
Contributor

I second this issue, I had to fix a bunch of wrong indentations because of variables like type_of_element or something like that, because they contain the string type. This pretty much only appeared in line continuations.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants