Support passing arguments to worker constructor

[shouichi]

Though rq.worker.Worker constructor accepts many arguments (https://github.com/rq/rq/blob/eaf598d73ce234791ee22ef82f7f095aece9f2a6/rq/worker.py#L159
), it seems that Flask-RQ2 does not support passing arguments to worker constructor. Do you guys want to support this feature?

Background

rq.worker.Worker uses hostname and pid for its name by default (https://github.com/rq/rq/blob/eaf598d73ce234791ee22ef82f7f095aece9f2a6/rq/worker.py#L239) but we run workers in container and hostname/pid are all the same. As a result, workers failed to start due to the duplicated name (https://github.com/rq/rq/blob/eaf598d73ce234791ee22ef82f7f095aece9f2a6/rq/worker.py#L275).

Thanks!

[jezdez]

Assuming you mean the RQ.get_worker method: yes. But we shouldn't simply pass all **kwargs to Worker but define some options that are shared in the RQ instance instead. In other words let's try to keep Flask-RQ2 a high-level API that hides some of the low-level features.

Here are the arguments that need to be added:

• name (add as RQ.worker_name?)
• default_result_ttl (reuse RQ.default_result_ttl)
• default_worker_ttl (add as RQ.default_worker_ttl)
• job_monitoring_interval (add as RQ.job_monitoring_interval, and add as option to worker CLI callback)

[shouichi]

But we shouldn't simply pass all **kwargs to Worker but define some options that are shared in the RQ instance instead. In other words let's try to keep Flask-RQ2 a high-level API that hides some of the low-level features.

Got it (I understand the RQ's goal is keeping it simple).

• name (add as RQ.worker_name?)

Make the default value None and allow users to pass arbitrary string. That why the RQ keeps the current behavior. Correct?

• job_monitoring_interval (add as RQ.job_monitoring_interval, and add as option to worker CLI callback)

Do you mean adding an option (@click.option) to this func?

Flask-RQ2/src/flask_rq2/cli.py

Line 136 in 94f8d2f

def worker(rq, ctx, burst, logging_level, name, path, results_ttl,

Thanks!

[alvin1]

From my use of Flask-RQ2, I'd like to add:
date_format
log_format

These 2 args are useful for the logging