rpmbuild -bs leaves an unnecessary name-version-build directory behind #3382
Comments
|
To me, this might be |
|
|
|
It's not a fedpkg thing, it's just that in the "traditional" ~/rpmbuild/{SPECS,BUILD,...} layout the directory gets created out of sigh, whereas fedpkg overrides all those to the current directory. It's a bug in rpmbuild. No need to speculate. There are ... somewhere over a hundred different combinations this stuff be invoked, and this one got overlooked. |
There are a bunch of flaws here, kinda separate items but as they were
all introduced in a single commit it probably makes sense to address
the mess as one too:
There was a missing 'break' causing %mkbuilddir to use the templates of
%prep, which masks the fact that the %__spec_builddir_* stuff all set
to %{nil} doesn't work, which causes us to try to 'cd' to the build
directory that we're about to create in that %mkbuilddir. It only
happens to work because I forgot to update the rpmMkdirs() call in
rpmbuild to create %_top_builddir instead of %_builddir. Oof.
The only obvious evidence of all that fubar was that rpmbuild -bs
started leaving an empty build directory behind.
Reported-by: Fabio Valentini <[email protected]>
Fixes: rpm-software-management#3382
|
And what a bug it was! Not the proudest day of my career 😆 Thanks a lot for reporting @decathorpe ! |
|
eh, we've all forgot to add |
Reported by @decathorpe in #3381:
Running
rpmbuild -bs <spec>leaves behind an empty name-version-build directory. If we need to create the dir, we should at least clean up afterwards (and cleaning up might be easier than trying to avoid creating)The text was updated successfully, but these errors were encountered: