Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adds support for ECDSA signatures #246

Merged
merged 1 commit into from
Nov 10, 2024
Merged

Adds support for ECDSA signatures #246

merged 1 commit into from
Nov 10, 2024

Conversation

baloo
Copy link
Contributor

@baloo baloo commented Nov 10, 2024 •
edited
Loading

📜 Checklist

  • Commits are cleanly separated and have useful messages
  • A changelog entry or entries has been added to CHANGELOG.md
  • Documentation is thorough
  • Test coverage is excellent and passes
  • Works when tests are run --all-features enabled

@baloo
Copy link
Contributor Author

baloo commented Nov 10, 2024

I think the support for ECDSA signature came in RPM 4.19 (as far as my testing went) but I could be wrong.

@dralley
Copy link
Collaborator

dralley commented Nov 10, 2024

Looks good! But please include a changelog entry before you check the box :)

@baloo
Copy link
Contributor Author

baloo commented Nov 10, 2024 via email

@baloo baloo force-pushed the baloo/ecdsa-support branch from 8714cd1 to 8775c78 Compare November 10, 2024 19:46
@dralley dralley merged commit 8a50048 into rpm-rs:master Nov 10, 2024
15 checks passed
@baloo baloo deleted the baloo/ecdsa-support branch November 10, 2024 19:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dralley dralley dralley approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@baloo @dralley