Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests: centos on docker hub went EOL #243

Merged
merged 2 commits into from
Nov 8, 2024

Conversation

baloo
Copy link
Contributor

@baloo baloo commented Nov 7, 2024

centos docker image went EOL in June 2024 and do not appear to be available on hub.docker.com anymore.

This breaks tests when you don't already have an image cached on your computer.

This commit migrates to one available on quay.io

📜 Checklist

  • Commits are cleanly separated and have useful messages
  • A changelog entry or entries has been added to CHANGELOG.md
  • Documentation is thorough
  • Test coverage is excellent and passes
  • Works when tests are run --all-features enabled

@dralley
Copy link
Collaborator

dralley commented Nov 8, 2024

CentOS Stream 9 is not EOL, it is an active distribution.

CentOS Stream is not the same as "CentOS".

@dralley dralley closed this Nov 8, 2024
@dralley dralley reopened this Nov 8, 2024
@dralley
Copy link
Collaborator

dralley commented Nov 8, 2024

Reopening this because despite what I said being correct, you are also correct that the Dockerhub image is gone.

If you can get the tests to use quay.io instead of dockerhub, that would be preferable. Likewise for Fedora.

https://quay.io/repository/centos/centos?tab=tags&tag=stream9

Though that may be a system-default-settings issue rather than a test issue?

centos docker image went EOL in June 2024 and do not appear to be
available on hub.docker.com anymore.

This breaks tests when you don't already have an image cached on your
computer.

This commit migrates to one available on quay.io
@baloo baloo force-pushed the baloo/tests/remove-centos branch from abf5c93 to 8ecdda7 Compare November 8, 2024 04:09
@baloo baloo changed the title tests: centos went EOL tests: centos on docker hub went EOL Nov 8, 2024
@baloo
Copy link
Contributor Author

baloo commented Nov 8, 2024

Reopening this because despite what I said being correct, you are also correct that the Dockerhub image is gone.

If you can get the tests to use quay.io instead of dockerhub, that would be preferable. Likewise for Fedora.

https://quay.io/repository/centos/centos?tab=tags&tag=stream9

Ha nice, I didn't know there was one on quay.io

Though that may be a system-default-settings issue rather than a test issue?

That could very well be, I'm not very knowledgeable about that.
But I don't believe tests should require the user to configure its system beyond what is reasonable. Referencing the image with it's full path is a better approach I think.

@dralley dralley merged commit de007dc into rpm-rs:master Nov 8, 2024
15 checks passed
@baloo baloo deleted the baloo/tests/remove-centos branch November 8, 2024 16:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants