-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add feature flags for compression algorithms #241
Conversation
What should I do about the failing tests on |
Flag the test on the availability of the compression for now I suppose. Could you explain your motivation for the PR - is it just reducing dependencies in a use case that doesn't require them? (That's perfectly fine, I'm just curious) |
20df642
to
1ca18c9
Compare
Mostly a use case that doesn't require anything else than zstd and we'd like to reduce the amount of C code we link against. |
dd61e5f
to
b7a93b9
Compare
This commit adds a feature flag for every compression algorithm. All compression algorithms are all enabled by default, but can be disabled in case they are not used to reduce the amount of dependencies.
b7a93b9
to
98f70fa
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
Do you have more changes planned? If not I can do a new release, otherwise I can wait. |
Decompressing content from archives would still be nice but implementing that would probably still take a few days. |
This pull request adds a feature flag for every compression algorithm. All compression algorithms are all enabled by default, but can be disabled in case they are not used to reduce the amount of dependencies.
Please note: I couldn't run all the tests because some containers are not found in the registry I am using.