Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixup changelog and other small things #190

Merged
merged 2 commits into from
Nov 3, 2023
Merged

Fixup changelog and other small things #190

merged 2 commits into from
Nov 3, 2023

Conversation

dralley
Copy link
Collaborator

@dralley dralley commented Oct 27, 2023

@dralley dralley force-pushed the master branch 2 times, most recently from 2b27543 to 4cfd23b Compare October 27, 2023 14:56
@dralley dralley force-pushed the master branch 6 times, most recently from cc6d823 to 8edf100 Compare October 28, 2023 01:59
@dralley dralley requested a review from cmeister2 October 28, 2023 16:47
@dralley
Copy link
Collaborator Author

dralley commented Oct 29, 2023

Anyone able to review this? @drahnr?

drahnr
drahnr reviewed Oct 30, 2023
View reviewed changes
src/rpm/headers/header.rs
Sha2_224(Vec<u8>),
pub struct FileDigest {
digest: String,
algo: DigestAlgorithm,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

drahnr
drahnr requested changes Oct 30, 2023
View reviewed changes
Copy link
Contributor

@drahnr drahnr left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the change to FileDigest is reasonable. The new public API requires documentation, the newly public API requires an improved documentation.

I am not convinced the conversions on style are more idiomatic or readable compared to their original content.

@dralley
Copy link
Collaborator Author

dralley commented Oct 30, 2023

I am not convinced the conversions on style are more idiomatic or readable compared to their original content.

What are you referring to specifically?

@dralley dralley force-pushed the master branch 4 times, most recently from 0824728 to 98236cb Compare October 30, 2023 15:00
@dralley dralley requested a review from drahnr October 30, 2023 15:33
drahnr
drahnr reviewed Oct 30, 2023
View reviewed changes
tests/parsing.rs Outdated Show resolved Hide resolved
@dralley dralley requested review from drahnr and removed request for olivierlemasle November 3, 2023 12:55
@dralley dralley removed the request for review from cmeister2 November 3, 2023 12:56
@dralley dralley merged commit 859e426 into rpm-rs:master Nov 3, 2023
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marxin marxin marxin left review comments

@drahnr drahnr drahnr approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@dralley @drahnr @marxin @olivierlemasle